[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2vxz8qd7z94n.fsf@kernel.org>
Date: Thu, 05 Feb 2026 13:07:36 +0100
From: Pratyush Yadav <pratyush@...nel.org>
To: Mike Rapoport <rppt@...nel.org>
Cc: Sasha Levin <sashal@...nel.org>, pasha.tatashin@...een.com,
pratyush@...nel.org, linux-kernel@...r.kernel.org, surenb@...gle.com
Subject: Re: [PATCH] kexec: allow KEXEC_HANDOVER to build with COMPILE_TEST
On Thu, Feb 05 2026, Mike Rapoport wrote:
> On Wed, Feb 04, 2026 at 01:28:16PM -0500, Sasha Levin wrote:
>> Currently allmodconfig sets CONFIG_DEFERRED_STRUCT_PAGE_INIT which prevents KHO
>> from building.
>>
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>> ---
>> kernel/liveupdate/Kconfig | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/kernel/liveupdate/Kconfig b/kernel/liveupdate/Kconfig
>> index d2aeaf13c3acb..355b43492b8a4 100644
>> --- a/kernel/liveupdate/Kconfig
>> +++ b/kernel/liveupdate/Kconfig
>> @@ -1,14 +1,14 @@
>> # SPDX-License-Identifier: GPL-2.0-only
>>
>> menu "Live Update and Kexec HandOver"
>> - depends on !DEFERRED_STRUCT_PAGE_INIT
>> + depends on !DEFERRED_STRUCT_PAGE_INIT || COMPILE_TEST
>>
>> config KEXEC_HANDOVER
>> bool "kexec handover"
>> - depends on ARCH_SUPPORTS_KEXEC_HANDOVER && ARCH_SUPPORTS_KEXEC_FILE
>> - depends on !DEFERRED_STRUCT_PAGE_INIT
>> + depends on (ARCH_SUPPORTS_KEXEC_HANDOVER && ARCH_SUPPORTS_KEXEC_FILE) || COMPILE_TEST
>
> I don't think we want to build this for all architectures.
> Let's keep depends on ARCH_ as it was.
Yep. All these test robot warnings are because a bunch of KHO/LUO code
assumes 64-bit arch.
>
>> + depends on !DEFERRED_STRUCT_PAGE_INIT || COMPILE_TEST
>> select MEMBLOCK_KHO_SCRATCH
>> - select KEXEC_FILE
>> + select KEXEC_FILE if ARCH_SUPPORTS_KEXEC_FILE
If arch does not support kexec_file we can't use KHO at all anyway. So I
am not sure if this makes sense.
>> select LIBFDT
>> select CMA
>> help
>> --
>> 2.51.0
>>
--
Regards,
Pratyush Yadav
Powered by blists - more mailing lists