linux-kernel - Re: [PATCH v4 2/5] netfilter: ftp: annotate nf_nat_ftp_hook with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABFUUZEF3w48iehUyx2Mcxwi0K6qNEja=7f1P6n1gq=AGv=daQ@mail.gmail.com>
Date: Thu, 5 Feb 2026 20:23:44 +0800
From: sun jian <sun.jian.kdev@...il.com>
To: Florian Westphal <fw@...len.de>
Cc: Pablo Neira Ayuso <pablo@...filter.org>, netfilter-devel@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/5] netfilter: ftp: annotate nf_nat_ftp_hook with __rcu

On Thu, Feb 5, 2026 at 6:00 PM Florian Westphal <fw@...len.de> wrote:
>
> Sun Jian <sun.jian.kdev@...il.com> wrote:
>
> Patch 1 re-indents, the rest doesn't.
>
> > diff --git a/net/netfilter/nf_conntrack_ftp.c b/net/netfilter/nf_conntrack_ftp.c
> CHECK: Alignment should match open parenthesis
> #135: FILE: net/netfilter/nf_conntrack_ftp.c:47:
> +unsigned int (__rcu *nf_nat_ftp_hook)(struct sk_buff *skb,
>                                 enum ip_conntrack_info ctinfo,
>
> Please re-indent in .c and check that checkpatch.pl doesn't complain.
>
> Also, no need to send this in multiple patches, its one logical
> annotation change.

Ack. I'll squash these into a single patch and fix the alignment issues.
v5 is coming soon.

Regards,
sun jian