linux-kernel - Re: [PATCH] dt-bindings: display: ti,am65x-dss: Add AM62L DSS support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45665c07-858a-4229-8dc9-d5db5470b95f@kernel.org>
Date: Thu, 5 Feb 2026 14:27:08 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Swamil Jain <s-jain1@...com>, Rob Herring <robh@...nel.org>
Cc: jyri.sarha@....fi, tomi.valkeinen@...asonboard.com, airlied@...il.com,
 simona@...ll.ch, maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
 tzimmermann@...e.de, krzk+dt@...nel.org, conor+dt@...nel.org,
 devarsht@...com, praneeth@...com, bb@...com, vigneshr@...com,
 dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: display: ti,am65x-dss: Add AM62L DSS support

On 30/01/2026 07:04, Swamil Jain wrote:
>>>>> +      properties:
>>>>> +        reg-names:
>>>>> +          items:
>>>>> +            - const: common
>>>>> +            - const: vidl1
>>>>> +            - const: vid
>>>>> +            - const: ovr1
>>>>> +            - const: ovr2
>>>>> +            - const: vp1
>>>>> +            - const: vp2
>>>>> +            - const: common1
>>>>
>>>> Why are you defining the names twice?
>>>>
>>>
>>> For AM62L we don't have "vid", "ovr2" and "vp2", the dtbs_check will fail.
>>> Could you please suggest a better way?
>>
>> You already defined them at the top level. Here in the if/then schema,
>> all you need is 'maxItems: 5' and 'minItems: 8'. But then you already
>> have that as well.
>>
>> Rob
> 
> Posted a v2[1], could you please review if the patch looks good?
> 
> [1]: https://lore.kernel.org/all/20260129150601.185882-1-s-jain1@ti.com/

It is not good. Rob asked you what to do. Read his second sentence. You
posted something completely different ignoring what he asked you. Also
ignoring rules stated in the docs.

Best regards,
Krzysztof