linux-kernel - Re: [PATCH v7 2/2] staging: axis-fifo: refactor device tree parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aYXxECAuS9nyWUia@stanley.mountain>
Date: Fri, 6 Feb 2026 16:48:00 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Gustavo Piaz da Silva <gustavopiazdasilva2102@...il.com>
Cc: gregkh@...uxfoundation.org, ovidiu.panait.oss@...il.com,
	gshahrouzi@...il.com, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 2/2] staging: axis-fifo: refactor device tree parsing

On Fri, Feb 06, 2026 at 10:11:48AM -0300, Gustavo Piaz da Silva wrote:
> -	ret = of_property_read_u32(node, "xlnx,axi-str-rxd-tdata-width",
> -				   &value);
> +	ret = of_property_read_u32(node, "xlnx,axi-str-rxd-tdata-width", &value);

You moved &value to the previous line which is the right thing.  But,
please, don't make these unrelated white space changes in the same patch.
You can do it in a separate patch but they make the diff harder to
review.

regards,
dan carpenter