linux-kernel - Re: [PATCH] mm/memory hotplug: Fix zone->contiguous always false when hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12f4c0eb-fcd0-4157-b668-d0e8340d8219@intel.com>
Date: Fri, 6 Feb 2026 22:08:26 +0800
From: "Li, Tianyou" <tianyou.li@...el.com>
To: "David Hildenbrand (Arm)" <david@...nel.org>, Oscar Salvador
	<osalvador@...e.de>, Mike Rapoport <rppt@...nel.org>, Wei Yang
	<richard.weiyang@...il.com>, Michal Hocko <mhocko@...e.com>, Andrew Morton
	<akpm@...ux-foundation.org>
CC: <linux-mm@...ck.org>, Yong Hu <yong.hu@...el.com>, Nanhai Zou
	<nanhai.zou@...el.com>, Yuan Liu <yuan1.liu@...el.com>, Tim Chen
	<tim.c.chen@...ux.intel.com>, Qiuxu Zhuo <qiuxu.zhuo@...el.com>, Yu C Chen
	<yu.c.chen@...el.com>, Pan Deng <pan.deng@...el.com>, Chen Zhang
	<zhangchen.kidd@...com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm/memory hotplug: Fix zone->contiguous always false when
 hotplug


On 2/6/2026 9:03 PM, David Hildenbrand (Arm) wrote
> On 1/30/26 17:09, Tianyou Li wrote:
>> From: Yuan Liu <yuan1.liu@...el.com>
>
> Nit: subject should start with "mm/memory_hotplug:"
>

Got it. My bad, will pay attention next time. Thanks David.


>>
>> set_zone_contiguous() uses __pageblock_pfn_to_page() to detect
>> pageblocks that either do not exist (hole) or that do not belong
>> to the same zone.
>>
>> __pageblock_pfn_to_page(), however, relies on pfn_to_online_page(),
>> effectively always returning NULL for memory ranges that were not
>> onlined yet. So when called on a range-to-be-onlined, it indicates
>> a memory hole to set_zone_contiguous().
>>
>> Consequently, the set_zone_contiguous() call in 
>> move_pfn_range_to_zone(),
>> which happens early during memory onlining, will never detect a
>> zone as being contiguous. Bad: the fast path relies on the zone
>> contiguous state may skipped.
>>
>> To fix the issue, move the set_zone_contiguous() call to a later
>> stage in memory onlining, where pfn_to_online_page() will succeed:
>> after we mark the memory sections to be online.
>>
>> Fixes: 2d070eab2e82 ("mm: consider zone which is not fully populated 
>> to have holes")
>> Cc: Michal Hocko <mhocko@...e.com>
>> Cc: stable@...r.kernel.org
>> Reviewed-by: Nanhai Zou <nanhai.zou@...el.com>
>> Signed-off-by: Yuan Liu <yuan1.liu@...el.com>
>> Signed-off-by: Tianyou Li <tianyou.li@...el.com>
>
> How was Yuan Liu involved? If he is a co-author there is a
>
>     Co-developed-by: Yuan Liu <yuan1.liu@...el.com>
>
> missing.
>

Yes, Yuan Liu co-author the patch. Thanks and I will pay attention next 
time. Appreciated.


>
> Likely there is no resend required if you tell Andrew what to do, so 
> he can just fixup when applying.
>
> Acked-by: David Hildenbrand (Arm) <david@...nel.org>
>

+ Andrew Morton for awareness.

Hi Andrew,

Please kindly let me know if resend required or you are willing to 
kindly fixup the titile and Co-developed-by tag for me. Appreciated in 
advance for any additional burden that costs.

Regards,

Tianyou