linux-kernel - Re: [bug report] io_uring: add task fork hook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b57cd15d-8e3d-474d-9c33-96f04a2a5499@kernel.dk>
Date: Fri, 6 Feb 2026 07:28:09 -0700
From: Jens Axboe <axboe@...nel.dk>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Dietmar Eggemann <dietmar.eggemann@....com>,
 Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>,
 Mel Gorman <mgorman@...e.de>, Valentin Schneider <vschneid@...hat.com>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 "Liam R. Howlett" <Liam.Howlett@...cle.com>, Vlastimil Babka
 <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>,
 Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko <mhocko@...e.com>,
 linux-mm@...ck.org, linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [bug report] io_uring: add task fork hook

On 2/6/26 6:40 AM, Dan Carpenter wrote:
> [ Smatch checking is paused while we raise funding.  #SadFace
>   https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ]
> 
> Hello Jens Axboe,
> 
> Commit 4f08520591a2 ("io_uring: add task fork hook") from Jan 16,
> 2026 (linux-next), leads to the following Smatch static checker
> warning:
> 
> 	kernel/fork.c:2544 copy_process()
> 	warn: passing zero to 'ERR_PTR'
> 
> kernel/fork.c
>   2128  #ifdef CONFIG_IO_URING
>   2129          p->io_uring = NULL;
>   2130          retval = io_uring_fork(p);
> 
> The patch added this assignment.
> 
>   2131          if (unlikely(retval))
>   2132                  goto bad_fork_cleanup_delayacct;
>   2133  #endif
>   2134  
>   2135          p->default_timer_slack_ns = current->timer_slack_ns;
>   2136  
>   2137  #ifdef CONFIG_PSI
>   2138          p->psi_flags = 0;
>   2139  #endif
>   2140  
>   2141          task_io_accounting_init(&p->ioac);
>   2142          acct_clear_integrals(p);
>   2143  
>   2144          posix_cputimers_init(&p->posix_cputimers);
>   2145          tick_dep_init_task(p);
>   2146  
>   2147          p->io_context = NULL;
>   2148          audit_set_context(p, NULL);
>   2149          cgroup_fork(p);
>   2150          if (args->kthread) {
>   2151                  if (!set_kthread_struct(p))
>   2152                          goto bad_fork_cleanup_delayacct;
> 
> So now retval is success where previously it had been -EAGAIN
> 
>   2153          }

Thanks, fixed up.

-- 
Jens Axboe