linux-kernel - Re: [PATCH] dlm: use hlist_for_each_entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK-6q+gW_a4NNsm7OAovoYy+QVNbqfv+9XR8GY7kp7Mv4vysMA@mail.gmail.com>
Date: Fri, 6 Feb 2026 09:44:06 -0500
From: Alexander Aring <aahringo@...hat.com>
To: lirongqing <lirongqing@...du.com>
Cc: David Teigland <teigland@...hat.com>, gfs2@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dlm: use hlist_for_each_entry_srcu for SRCU protected lists

Hi,

On Fri, Feb 6, 2026 at 12:19 AM lirongqing <lirongqing@...du.com> wrote:
>
> From: Li RongQing <lirongqing@...du.com>
>
> The connection and node hash tables in DLM are protected by SRCU, but
> the code currently uses hlist_for_each_entry_rcu() for traversal.
> While this works functionally, it is semantically incorrect and triggers
> warnings when RCU lockdep debugging is enabled, as it expects regular
> RCU read-side critical sections.
>

I noticed this as well and came to the same conclusion that it doesn't
matter, but I do agree we should change that because the API can be
changed even in the non debug case.

So thanks for doing this...

Acked-by: Alexander Aring <aahringo@...hat.com>

- Alex