linux-kernel - Re: [PATCH rdma-next v3 1/1] RDMA/mana

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260206145011.GJ943673@ziepe.ca>
Date: Fri, 6 Feb 2026 10:50:11 -0400
From: Jason Gunthorpe <jgg@...pe.ca>
To: Konstantin Taranov <kotaranov@...ux.microsoft.com>
Cc: kotaranov@...rosoft.com, shirazsaleem@...rosoft.com,
	longli@...rosoft.com, leon@...nel.org, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH rdma-next v3 1/1] RDMA/mana_ib: return PD number to the
 user

On Fri, Feb 06, 2026 at 06:36:46AM -0800, Konstantin Taranov wrote:
> From: Konstantin Taranov <kotaranov@...rosoft.com>
> 
> Implement returning to userspace applications PDNs of created PDs.
> The PDN is used by applications that build work requests outside of the
> rdma-core code base. The PDN is used to build work requests that require
> mentioning the PD. The MANA HW still ensures PD isolation using PDN attached
> to MRs and WRs, therefore the PDN mentioned in the work request must match
> the PDN of the used work queue. The work requests can fit only 16 bit PDNs.
> Allow users to request short PDNs which are 16 bits.

Okay, if you say so.. What a crazy thing to do, and not enough bits to
boot.

Anyhow, same comment as broadcom, the driver has to implement the
driver data forwards/back compat protocol properly before you can add
new drvdata extensions.

ie if userspace sends MANA_IB_PD_SHORT_PDN the current kernels will
just ignore it without EOPNOTSUPP, that is not OK.

So you need to do the mana version of this series:

https://lore.kernel.org/linux-rdma/0-v1-89ea7d615ba4+636-bnxt_re_uapi_jgg@nvidia.com/

And I have already written alot of the required mana parts here:

https://github.com/jgunthorpe/linux/commits/rdma_uapi/

Feel free to pull them out and make mana changes matching the broadcom ones:

  RDMA/bnxt_re: Add compatibility checks to the uapi path
  RDMA/bnxt_re: Add compatibility checks to the uapi path for no data
  RDMA/bnxt_re: Add missing comp_mask validation
  RDMA/bnxt_re: Use ib_respond_udata()
  RDMA/bnxt_re: Add BNXT_RE_UCNTX_CMASK_UAPI_COMPAT_SUPPORTED

We can take it after the merge window closes in two weeks.

Jason