linux-kernel - Re: ksm: initialize rmap values directly and make them const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYYIw3h35HOqodAb@casper.infradead.org>
Date: Fri, 6 Feb 2026 15:29:07 +0000
From: Matthew Wilcox <willy@...radead.org>
To: xu.xin16@....com.cn
Cc: david@...nel.org, akpm@...ux-foundation.org, chengming.zhou@...ux.dev,
	hughd@...gle.com, wang.yaxin@....com.cn, yang.yang29@....com.cn,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: ksm: initialize rmap values directly and make them const

On Fri, Feb 06, 2026 at 03:22:54PM +0800, xu.xin16@....com.cn wrote:
> make them const to make code more robust. Besides, since KSM folios are always
> order-0, so folio_nr_pages(KSM folio) is always 1, so the line:
> 
> 	"pgoff_end = pgoff_start + folio_nr_pages(folio) - 1;"
> 
> becomes directly:
> 
> 	"pgoff_end = pgoff_start;"

How do you know KSM folios will always be order 0?  I don't.  NAK this
change.