linux-kernel - Re: [PATCH v4 01/26] KVM: SVM: Switch svm_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYYO0WqVDTSA8siv@google.com>
Date: Fri, 6 Feb 2026 07:54:57 -0800
From: Sean Christopherson <seanjc@...gle.com>
To: Yosry Ahmed <yosry.ahmed@...ux.dev>
Cc: Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	stable@...r.kernel.org
Subject: Re: [PATCH v4 01/26] KVM: SVM: Switch svm_copy_lbrs() to a macro

On Fri, Feb 06, 2026, Yosry Ahmed wrote:
> On Thu, Feb 05, 2026 at 05:25:15PM -0800, Sean Christopherson wrote:
> > On Fri, Feb 06, 2026, Yosry Ahmed wrote:
> > @@ -848,8 +859,6 @@ void svm_copy_lbrs(struct vmcb *to_vmcb, struct vmcb *from_vmcb)
> >         to_vmcb->save.br_to             = from_vmcb->save.br_to;
> >         to_vmcb->save.last_excp_from    = from_vmcb->save.last_excp_from;
> >         to_vmcb->save.last_excp_to      = from_vmcb->save.last_excp_to;
> > -
> > -       vmcb_mark_dirty(to_vmcb, VMCB_LBR);
> >  }
> >  
> >  static void __svm_enable_lbrv(struct kvm_vcpu *vcpu)
> > @@ -877,6 +886,8 @@ void svm_update_lbrv(struct kvm_vcpu *vcpu)
> >                             (is_guest_mode(vcpu) && guest_cpu_cap_has(vcpu, X86_FEATURE_LBRV) &&
> >                             (svm->nested.ctl.virt_ext & LBR_CTL_ENABLE_MASK));
> >  
> > +       vmcb_mark_dirty(svm->vmcb, VMCB_LBR);
> > +
> 
> Although I would rather keep this in callers of svm_copy_lbrs(), instead
> of hiding it here. 

No objection on my end.