linux-kernel - Re: [PATCH v1 1/2] perf tests: build-test coverage for NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260206160936.GG3529712@e132581.arm.com>
Date: Fri, 6 Feb 2026 16:09:36 +0000
From: Leo Yan <leo.yan@....com>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Ian Rogers <irogers@...gle.com>, Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, Namhyung Kim <namhyung@...nel.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	James Clark <james.clark@...aro.org>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] perf tests: build-test coverage for NO_JEVENTS=1

On Fri, Feb 06, 2026 at 11:59:25AM -0300, Arnaldo Carvalho de Melo wrote:
> On Fri, Feb 06, 2026 at 08:53:49AM +0000, Leo Yan wrote:
> > On Thu, Feb 05, 2026 at 10:36:02AM -0800, Ian Rogers wrote:
> > > Leo reported the NO_JEVENTS=1 build being broken and this highlighted
> > > it being missing from the build-test, add it.
> > 
> > To be clear, I did not say the build is broken.
> > 
> > The issue I reported is that `perf stat` is broken, both with
> > NO_JEVENTS=1 enabled and without that configuration.
> > 
> > With updating the commit log, this patch LGTM:
> 
> I did it and will apply the Reviewed-by to patch 2/2 too, ok?

Yes, this is fine for me.

Just remind, in patch 02, based on test, we only need to apply the
change in metricgroup__parse_groups() for removing the "!table" check.

The change for metricgroup__has_metric_or_groups() is not quite right,
as we should keep the searching metrics with
pmu_metrics_table__default().

Thanks,
Leo