linux-kernel - Re: [PATCH v1 1/3] KVM: s390: Use guest address to mark guest page dirty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260206162912.38172-A-seiden@linux.ibm.com>
Date: Fri, 6 Feb 2026 17:29:12 +0100
From: Steffen Eiden <seiden@...ux.ibm.com>
To: Claudio Imbrenda <imbrenda@...ux.ibm.com>
Cc: kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-s390@...r.kernel.org, borntraeger@...ibm.com,
        frankja@...ux.ibm.com, nsg@...ux.ibm.com, nrb@...ux.ibm.com,
        gra@...ux.ibm.com, schlameuss@...ux.ibm.com, hca@...ux.ibm.com,
        svens@...ux.ibm.com, agordeev@...ux.ibm.com, gor@...ux.ibm.com,
        david@...nel.org, gerald.schaefer@...ux.ibm.com
Subject: Re: [PATCH v1 1/3] KVM: s390: Use guest address to mark guest page
 dirty

On Fri, Feb 06, 2026 at 03:35:51PM +0100, Claudio Imbrenda wrote:
> Stop using the userspace address to mark the guest page dirty.
> mark_page_dirty() expects a guest frame number, but was being passed a
> host virtual frame number. When slot == NULL, mark_page_dirty_in_slot()
> does nothing and does not complain.
> 
> This means that in some circumstances the dirtiness of the guest page
> might have been lost.
> 
> Fix by adding two fields in struct kvm_s390_adapter_int to keep the
> guest addressses, and use those for mark_page_dirty().
> 
> Fixes: f65470661f36 ("KVM: s390/interrupt: do not pin adapter interrupt pages")
> Signed-off-by: Claudio Imbrenda <imbrenda@...ux.ibm.com>
Great catch!

Reviewed-by: Steffen Eiden <seiden@...ux.ibm.com>

...