linux-kernel - Re: [PATCH v2] reset: imx7: Check return value of regmap_attach_dev() in imx7_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aYYXC-aS2UgFxfLl@lizhi-Precision-Tower-5810>
Date: Fri, 6 Feb 2026 11:30:03 -0500
From: Frank Li <Frank.li@....com>
To: Chen Ni <nichen@...as.ac.cn>
Cc: p.zabel@...gutronix.de, s.hauer@...gutronix.de, kernel@...gutronix.de,
	festevam@...il.com, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] reset: imx7: Check return value of
 regmap_attach_dev() in imx7_reset_probe()

On Fri, Feb 06, 2026 at 01:01:09PM +0800, Chen Ni wrote:
> Add error checking for regmap_attach_dev() call in imx7_reset_probe()
> function to ensure proper error propagation.
>
> Return the value of regmap_attach_dev() if it fails to prevent
> proceeding with an incomplete regmap setup.
>
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
Reviewed-by: Frank Li <Frank.Li@....com>
> Changes in v2:
> - Simplify error handling
> ---
>  drivers/reset/reset-imx7.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/reset/reset-imx7.c b/drivers/reset/reset-imx7.c
> index dd01fe11c5cb..a1cca926085b 100644
> --- a/drivers/reset/reset-imx7.c
> +++ b/drivers/reset/reset-imx7.c
> @@ -364,6 +364,7 @@ static int imx7_reset_probe(struct platform_device *pdev)
>  	struct device *dev = &pdev->dev;
>  	struct regmap_config config = { .name = "src" };
>  	const struct imx7_src_variant *variant = of_device_get_match_data(dev);
> +	int ret;
>
>  	imx7src = devm_kzalloc(dev, sizeof(*imx7src), GFP_KERNEL);
>  	if (!imx7src)
> @@ -375,7 +376,9 @@ static int imx7_reset_probe(struct platform_device *pdev)
>  		dev_err(dev, "Unable to get imx7-src regmap");
>  		return PTR_ERR(imx7src->regmap);
>  	}
> -	regmap_attach_dev(dev, imx7src->regmap, &config);
> +	ret = regmap_attach_dev(dev, imx7src->regmap, &config);
> +	if (ret)
> +		return ret;
>
>  	imx7src->rcdev.owner     = THIS_MODULE;
>  	imx7src->rcdev.nr_resets = variant->signals_num;
> --
> 2.25.1
>