linux-kernel - Re: [PATCH v3 1/2] dt-bindings: hwmon: add support for MCP998X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9d4b53f-d8c2-4b31-aa13-901838c2933c@kernel.org>
Date: Fri, 6 Feb 2026 17:47:31 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: victor.duicu@...rochip.com, linux@...ck-us.net, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, corbet@....net
Cc: marius.cristea@...rochip.com, linux-hwmon@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-doc@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: add support for MCP998X

On 27/01/2026 16:18, victor.duicu@...rochip.com wrote:
> From: Victor Duicu <victor.duicu@...rochip.com>
> 
> This is the devicetree schema for Microchip MCP998X/33 and
> MCP998XD/33D Multichannel Automotive Temperature Monitor Family.
> 
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> Signed-off-by: Victor Duicu <victor.duicu@...rochip.com>
> ---
>  .../bindings/hwmon/microchip,mcp9982.yaml     | 205 ++++++++++++++++++
>  MAINTAINERS                                   |   6 +
>  2 files changed, 211 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/microchip,mcp9982.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/microchip,mcp9982.yaml b/Documentation/devicetree/bindings/hwmon/microchip,mcp9982.yaml
> new file mode 100644
> index 000000000000..05ea3c6a5618
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/microchip,mcp9982.yaml
> @@ -0,0 +1,205 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/microchip,mcp9982.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip MCP998X/33 and MCP998XD/33D Temperature Monitor
> +
> +maintainers:
> +  - Victor Duicu <victor.duicu@...rochip.com>
> +
> +description: |
> +  The MCP998X/33 and MCP998XD/33D family is a high-accuracy 2-wire
> +  multichannel automotive temperature monitor.
> +  The datasheet can be found here:
> +    https://ww1.microchip.com/downloads/aemDocuments/documents/MSLD/ProductDocuments/DataSheets/MCP998X-Family-Data-Sheet-DS20006827.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - microchip,mcp9933
> +      - microchip,mcp9933d
> +      - microchip,mcp9982
> +      - microchip,mcp9982d
> +      - microchip,mcp9983
> +      - microchip,mcp9983d
> +      - microchip,mcp9984
> +      - microchip,mcp9984d
> +      - microchip,mcp9985
> +      - microchip,mcp9985d
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    items:
> +      - description: Signal coming from ALERT/THERM pin.
> +      - description: Signal coming from THERM/ADDR pin.
> +      - description: Signal coming from SYS_SHDN pin.

As Guenter pointed out - code is wrong (thanks Guenter!)

This does not match your if:then:.

> +
> +  interrupt-names:
> +    items:
> +      - const: alert-therm
> +      - const: therm-addr
> +      - const: sys-shutdown

Neither this.


...

> +    then:
> +      properties:
> +        interrupts-names:
> +          items:
> +            - const: alert-therm
> +            - const: sys-shutdown

So three interrupts, but two AND three interrupt-names? This is mess.

> +      required:
> +        - microchip,power-state
> +    else:
> +      properties:
> +        interrupts-names:
> +          items:
> +            - const: alert-therm
> +            - const: therm-addr

Where are all b4 lore links for previous versions so I can trace the
actual review happening here? Why aren't you using b4?

Best regards,
Krzysztof