linux-kernel - Re: [PATCH v3 0/2] add support in hwmon for MCP998X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <26a84810-df70-47b7-a60a-2b74babcd73e@kernel.org>
Date: Fri, 6 Feb 2026 17:55:33 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: victor.duicu@...rochip.com, linux@...ck-us.net, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, corbet@....net
Cc: marius.cristea@...rochip.com, linux-hwmon@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-doc@...r.kernel.org
Subject: Re: [PATCH v3 0/2] add support in hwmon for MCP998X

On 27/01/2026 16:18, victor.duicu@...rochip.com wrote:
> From: Victor Duicu <victor.duicu@...rochip.com>
> 
> Add support in hwmon for Microchip MCP998X/33 and MCP998XD/33D Multichannel
> Automotive Temperature Monitor Family.
> 
> The chips in the family have different numbers of external channels,
> ranging from 1 (MCP9982) to 4 channels (MCP9985).
> Reading diodes in anti-parallel connection is supported by MCP9984/85/33
> and MCP9984D/85D/33D. Dedicated hardware shutdown circuitry is present
> only in MCP998XD and MCP9933D.
> 
> The driver supports reading the temperature channels, the temperature
> limits and their corresponding alarms. The user can set the limits,
> the update interval and the hysteresis.
> 
> This driver is based on the IIO driver for MCP998X:
> https://lore.kernel.org/all/20250930133131.13797-1-victor.duicu@microchip.com/
> 
> Differences related to previous patch:
> v3:

That's v9 and I already asked you to start numbering this correctly and
include ENTIRE previous changelog.

What's more important you ignored several people's feedback over the
time. Did not implement it and did not respond to it. These were several
people, David, me, Andy, Jonathan - you ignored all of them?

Lack of responses from you mean this review is pointless and I will be
just NAKing your patches.


Best regards,
Krzysztof