linux-kernel - Re: [PATCH v4 21/26] KVM: SVM: Rename vmcb->virt_ext to vmcb->misc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aYYr4R2tgwaajwjQ@google.com>
Date: Fri, 6 Feb 2026 09:58:57 -0800
From: Sean Christopherson <seanjc@...gle.com>
To: Yosry Ahmed <yosry.ahmed@...ux.dev>
Cc: Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 21/26] KVM: SVM: Rename vmcb->virt_ext to vmcb->misc_ctl2

On Fri, Feb 06, 2026, Yosry Ahmed wrote:
> On Thu, Feb 05, 2026 at 05:31:01PM -0800, Sean Christopherson wrote:
> > On Thu, Jan 15, 2026, Yosry Ahmed wrote:
> > > @@ -244,6 +241,8 @@ struct __attribute__ ((__packed__)) vmcb_control_area {
> > >  #define SVM_MISC_CTL_SEV_ENABLE		BIT(1)
> > >  #define SVM_MISC_CTL_SEV_ES_ENABLE	BIT(2)
> > >  
> > > +#define SVM_MISC_CTL2_LBR_CTL_ENABLE		BIT_ULL(0)
> > > +#define SVM_MISC_CTL2_V_VMLOAD_VMSAVE_ENABLE	BIT_ULL(1)
> > 
> > Since you're changing names anyways, What do you think about shortening things
> > a bit, and using the more standard syle of <scope>_<action>_<flag>?  E.g.
> > 
> >   #define SVM_MISC2_ENABLE_LBR_VIRTUALIZATION	BIT_ULL(0)
> >   #define SVM_MISC2_ENABLE_V_VMLOAD_VMSAVE	BIT_ULL(1)
> 
> SVM_MISC2_ENABLE_LBR_VIRTUALIZATION is actually longer,

Heh, yeah, I knew that when I hit "send", I just wasn't sure if V_LBR was a good
name.

> how about SVM_MISC2_ENABLE_V_LBR? Shorter and more consistent with
> SVM_MISC2_ENABLE_V_VMLOAD_VMSAVE.

Works for me.  I was mildly concerned that V_LBR wouldn't be intuitive, but since
you independently came up with the name too, apparently not :-)