linux-kernel - Re: [PATCH v5 6/7] sample: rust: pci: use `register!` macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DG83X51TV560.26VQQD3B7WJL9@kernel.org>
Date: Fri, 06 Feb 2026 19:57:04 +0100
From: "Danilo Krummrich" <dakr@...nel.org>
To: "Alexandre Courbot" <acourbot@...dia.com>
Cc: "Alice Ryhl" <aliceryhl@...gle.com>, "Daniel Almeida"
 <daniel.almeida@...labora.com>, "Miguel Ojeda" <ojeda@...nel.org>, "Boqun
 Feng" <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Benno Lossin"
 <lossin@...nel.org>, "Andreas Hindborg" <a.hindborg@...nel.org>, "Trevor
 Gross" <tmgross@...ch.edu>, "Yury Norov" <yury.norov@...il.com>, "John
 Hubbard" <jhubbard@...dia.com>, "Alistair Popple" <apopple@...dia.com>,
 "Joel Fernandes" <joelagnelf@...dia.com>, "Timur Tabi" <ttabi@...dia.com>,
 "Edwin Peer" <epeer@...dia.com>, "Eliot Courtney" <ecourtney@...dia.com>,
 "Dirk Behme" <dirk.behme@...bosch.com>, "Steven Price"
 <steven.price@....com>, <rust-for-linux@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, "Zhi Wang" <zhiw@...dia.com>
Subject: Re: [PATCH v5 6/7] sample: rust: pci: use `register!` macro

On Thu Jan 29, 2026 at 2:32 PM CET, Alexandre Courbot wrote:
> Convert the direct IO accesses to properly defined registers.
>
> Tested-by: Zhi Wang <zhiw@...dia.com>
> Signed-off-by: Alexandre Courbot <acourbot@...dia.com>

I think you forgot the address my comment from [1].

Changing the config space is nice, but I think it would be even nicer to replace
the raw register writes and reads of the pci::Bar.

[1] https://lore.kernel.org/all/DG2DEH4ELYHK.2KUOIDQAILZHT@kernel.org/