linux-kernel - Re: [PATCH v3 25/30] gpu: nova-core: Hopper/Blackwell: larger WPR2 (GSP) heap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ae11f5dc8fb4058fd4f05ec7dafd493a6df5f22.camel@nvidia.com>
Date: Fri, 6 Feb 2026 19:03:23 +0000
From: Timur Tabi <ttabi@...dia.com>
To: Alexandre Courbot <acourbot@...dia.com>, "dakr@...nel.org"
	<dakr@...nel.org>, John Hubbard <jhubbard@...dia.com>
CC: "aliceryhl@...gle.com" <aliceryhl@...gle.com>, "lossin@...nel.org"
	<lossin@...nel.org>, "a.hindborg@...nel.org" <a.hindborg@...nel.org>,
	"boqun.feng@...il.com" <boqun.feng@...il.com>, Zhi Wang <zhiw@...dia.com>,
	"simona@...ll.ch" <simona@...ll.ch>, "alex.gaynor@...il.com"
	<alex.gaynor@...il.com>, "ojeda@...nel.org" <ojeda@...nel.org>,
	"tmgross@...ch.edu" <tmgross@...ch.edu>, "nouveau@...ts.freedesktop.org"
	<nouveau@...ts.freedesktop.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "rust-for-linux@...r.kernel.org"
	<rust-for-linux@...r.kernel.org>, "bjorn3_gh@...tonmail.com"
	<bjorn3_gh@...tonmail.com>, Eliot Courtney <ecourtney@...dia.com>,
	"airlied@...il.com" <airlied@...il.com>, Joel Fernandes
	<joelagnelf@...dia.com>, "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"gary@...yguo.net" <gary@...yguo.net>, Alistair Popple <apopple@...dia.com>
Subject: Re: [PATCH v3 25/30] gpu: nova-core: Hopper/Blackwell: larger WPR2
 (GSP) heap

On Thu, 2026-02-05 at 20:21 -0800, John Hubbard wrote:
> +    fn client_alloc_size(chipset: Chipset) -> u64 {
> +        if crate::fb::hal::fb_hal(chipset)
> +            .non_wpr_heap_size()
> +            .is_some()
> +        {
> +            GSP_FW_HEAP_PARAM_CLIENT_ALLOC_SIZE_GH100
> +        } else {
> +            u64::from(bindings::GSP_FW_HEAP_PARAM_CLIENT_ALLOC_SIZE)
> +        }
> +        .align_up(GSP_HEAP_ALIGNMENT)
> +        .unwrap_or(u64::MAX)

I understand not wanting to return a Result<> for impossible situations, but I don't know if this is
the answer.  For one thing, there is no way we can allocate a heap that large.  

Maybe we need to have some kind of infallible align_up() variant, but in this case, I would say a
panic is warranted.