linux-kernel - Re: [PATCH] crypto: testmgr - Add test vectors for authenc(hmac(md5),cbc(des3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3622af67-b083-488a-998a-29b8657be73a@wp.pl>
Date: Fri, 6 Feb 2026 20:40:18 +0100
From: Aleksander Jan Bajkowski <olek2@...pl>
To: Herbert Xu <herbert@...dor.apana.org.au>
Cc: davem@...emloft.net, mcoquelin.stm32@...il.com,
 alexandre.torgue@...s.st.com, linux-crypto@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: testmgr - Add test vectors for
 authenc(hmac(md5),cbc(des3_ede))

Hi Herbert,

On 2/6/26 12:01, Herbert Xu wrote:
> On Sun, Feb 01, 2026 at 12:27:08PM +0100, Aleksander Jan Bajkowski wrote:
>> Test vector was generated using a software implementation and then double
>> checked using a hardware implementation on NXP P2020 (talitos). The
>> encryption part is identical to authenc(hmac(sha1),cbc(des3_ede)),
>> only HMAC is different.
>>
>> Signed-off-by: Aleksander Jan Bajkowski <olek2@...pl>
>> ---
>>   crypto/testmgr.c |  7 ++++++
>>   crypto/testmgr.h | 59 ++++++++++++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 66 insertions(+)
> Patch applied.  Thanks.

While resolving the conflict, the entry was added in the wrong place. As a
result, the test manager complains about sorting:
[    0.050891] testmgr: alg_test_descs entries in wrong order: 
'authenc(hmac(md5),ecb(cipher_null))' before 
'authenc(hmac(md5),cbc(des3_ede))'

Should I send a patch to fix the sorting? Or would you prefer to replace
the patch in your tree and apply [1] first, then [2]? That way there should
be no conflicts.

1. 
https://patchwork.kernel.org/project/linux-crypto/patch/20260131174020.3670-1-olek2@wp.pl/
2. 
https://patchwork.kernel.org/project/linux-crypto/patch/20260201112834.3378-1-olek2@wp.pl/

Best regards,
Aleksander