linux-kernel - Re: [PATCH v2] audit: Avoid excessive dput/dget in audit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260206203838.GB3183987@ZenIV>
Date: Fri, 6 Feb 2026 20:38:38 +0000
From: Al Viro <viro@...iv.linux.org.uk>
To: Waiman Long <llong@...hat.com>
Cc: Paul Moore <paul@...l-moore.com>, Eric Paris <eparis@...hat.com>,
	Christian Brauner <brauner@...nel.org>,
	linux-kernel@...r.kernel.org, audit@...r.kernel.org,
	Richard Guy Briggs <rgb@...hat.com>,
	Ricardo Robaina <rrobaina@...hat.com>
Subject: Re: [PATCH v2] audit: Avoid excessive dput/dget in audit_context
 setup and reset paths

On Fri, Feb 06, 2026 at 03:04:53PM -0500, Waiman Long wrote:

> I guess if private means fs->users == 1, the condition could still be true.

Yes.  And then there's an oh-so-lovely wart wrt. chroot_fs_refs() and
exclusion for it.  See another reply re unspeakable[*] elegance of the
proof of correctness for that stuff ;-/

Annoyed much more than usual,
				Al

[*] there are some limits to what I'm willing to say on a family-friendly
maillist...