linux-kernel - Re: [PATCH v5 4/5] regulator: p3h2x4x: Add driver for on-die regulators in NXP P3H2x4x i3c hub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202602070610.sRd2Eapf-lkp@intel.com>
Date: Sat, 7 Feb 2026 06:19:11 +0800
From: kernel test robot <lkp@...el.com>
To: Aman Kumar Pandey <aman.kumarpandey@....com>,
	linux-kernel@...r.kernel.org, linux-i3c@...ts.infradead.org,
	alexandre.belloni@...tlin.com, krzk+dt@...nel.org, robh@...nel.org,
	conor+dt@...nel.org, devicetree@...r.kernel.org, broonie@...nel.org,
	lee@...nel.org, Frank.Li@....com, lgirdwood@...il.com
Cc: oe-kbuild-all@...ts.linux.dev, vikash.bansal@....com,
	priyanka.jain@....com, shashank.rebbapragada@....com,
	Aman Kumar Pandey <aman.kumarpandey@....com>
Subject: Re: [PATCH v5 4/5] regulator: p3h2x4x: Add driver for on-die
 regulators in NXP P3H2x4x i3c hub

Hi Aman,

kernel test robot noticed the following build warnings:

[auto build test WARNING on lee-mfd/for-mfd-next]
[also build test WARNING on lee-mfd/for-mfd-fixes broonie-regulator/for-next linus/master v6.19-rc8]
[cannot apply to i3c/i3c/next next-20260205]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Aman-Kumar-Pandey/dt-bindings-i3c-Add-NXP-P3H2x4x-i3c-hub-support/20260206-200552
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
patch link:    https://lore.kernel.org/r/20260206120121.856471-4-aman.kumarpandey%40nxp.com
patch subject: [PATCH v5 4/5] regulator: p3h2x4x: Add driver for on-die regulators in NXP P3H2x4x i3c hub
config: nios2-allmodconfig (https://download.01.org/0day-ci/archive/20260207/202602070610.sRd2Eapf-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260207/202602070610.sRd2Eapf-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602070610.sRd2Eapf-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/regulator/p3h2840_i3c_hub_regulator.c: In function 'p3h2x4x_regulator_probe':
>> drivers/regulator/p3h2840_i3c_hub_regulator.c:208:13: warning: unused variable 'ret' [-Wunused-variable]
     208 |         int ret, i;
         |             ^~~


vim +/ret +208 drivers/regulator/p3h2840_i3c_hub_regulator.c

   200	
   201	static int p3h2x4x_regulator_probe(struct platform_device *pdev)
   202	{
   203		struct p3h2x4x_dev *p3h2x4x = dev_get_drvdata(pdev->dev.parent);
   204		struct p3h2x4x_regulator_dev *p3h2x4x_regulator;
   205		struct regulator_config rcfg = { };
   206		struct device *dev = &pdev->dev;
   207		struct regulator_dev *rdev;
 > 208		int ret, i;
   209	
   210		p3h2x4x_regulator = devm_kzalloc(dev, sizeof(*p3h2x4x_regulator), GFP_KERNEL);
   211		if (!p3h2x4x_regulator)
   212			return -ENOMEM;
   213	
   214		platform_set_drvdata(pdev, p3h2x4x_regulator);
   215	
   216		p3h2x4x_regulator->regmap = p3h2x4x->regmap;
   217		device_set_of_node_from_dev(dev, dev->parent);
   218	
   219		rcfg.dev = dev;
   220		rcfg.dev->of_node = dev->of_node;
   221		rcfg.regmap = p3h2x4x_regulator->regmap;
   222		rcfg.driver_data = p3h2x4x_regulator;
   223	
   224		for (i = 0; i < ARRAY_SIZE(p3h2x4x_regulators); i++) {
   225			rdev = devm_regulator_register(&pdev->dev, &p3h2x4x_regulators[i], &rcfg);
   226			if (IS_ERR(rdev)) {
   227				return dev_err_probe(dev, PTR_ERR(rdev), "Failed to register %s\n",
   228						     p3h2x4x_regulators[i].name);
   229			}
   230			p3h2x4x_regulator->rp3h2x4x_dev[i] = rdev;
   231		}
   232		return 0;
   233	}
   234	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki