linux-kernel - Re: [PATCH net-next v3 0/4] amd-xgbe: add ARP offload and RSS self-tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260205190904.78be3190@kernel.org>
Date: Thu, 5 Feb 2026 19:09:04 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Raju Rangoju <Raju.Rangoju@....com>
Cc: <netdev@...r.kernel.org>, <pabeni@...hat.com>, <edumazet@...gle.com>,
 <davem@...emloft.net>, <andrew+netdev@...n.ch>,
 <linux-kernel@...r.kernel.org>, <Shyam-sundar.S-k@....com>
Subject: Re: [PATCH net-next v3 0/4] amd-xgbe: add ARP offload and RSS
 self-tests

On Wed, 4 Feb 2026 20:28:29 +0530 Raju Rangoju wrote:
>   amd-xgbe: do not select NET_SELFTESTS when INET is disabled

I'll apply this one

>   amd-xgbe: add hardware ARP offload support
>   amd-xgbe: add ARP offload ethtool self-test

These two I don't get. The feature is enabled during the test but it
can't be enabled by a normal user. So what's the point of testing it?

>   amd-xgbe: add RSS ethtool self-test

xgbe seems to implement Toeplitz hash, much better to run
tools/testing/selftests/drivers/net/hw/toeplitz.py
than just checking if the hash value != 0..