linux-kernel - RE: [PATCH] remoteproc: imx_rproc: Check return value of regmap_attach_dev() in imx_rproc_mmio_detect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB845965AFE2E08959C4CCB2BF8866A@PAXPR04MB8459.eurprd04.prod.outlook.com>
Date: Fri, 6 Feb 2026 03:41:02 +0000
From: Peng Fan <peng.fan@....com>
To: Peng Fan <peng.fan@....com>, Chen Ni <nichen@...as.ac.cn>,
	"andersson@...nel.org" <andersson@...nel.org>, "mathieu.poirier@...aro.org"
	<mathieu.poirier@...aro.org>, Frank Li <frank.li@....com>,
	"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>, "kernel@...gutronix.de"
	<kernel@...gutronix.de>, "festevam@...il.com" <festevam@...il.com>
CC: "linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] remoteproc: imx_rproc: Check return value of
 regmap_attach_dev() in imx_rproc_mmio_detect_mode()

> Subject: RE: [PATCH] remoteproc: imx_rproc: Check return value of
> regmap_attach_dev() in imx_rproc_mmio_detect_mode()
> 
> > Subject: [PATCH] remoteproc: imx_rproc: Check return value of
> > regmap_attach_dev() in imx_rproc_mmio_detect_mode()
> >
> > Add error checking for regmap_attach_dev() call in
> > imx_rproc_mmio_detect_mode() function to ensure proper error
> > propagation.
> >
> > Return the value of regmap_attach_dev() if it fails to prevent
> > proceeding with an incomplete regmap setup.
> >
> > Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> > ---
> >  drivers/remoteproc/imx_rproc.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/remoteproc/imx_rproc.c
> > b/drivers/remoteproc/imx_rproc.c index
> f5f916d67905..0e23f519c247
> > 100644
> > --- a/drivers/remoteproc/imx_rproc.c
> > +++ b/drivers/remoteproc/imx_rproc.c
> > @@ -1007,7 +1007,9 @@ static int
> > imx_rproc_mmio_detect_mode(struct rproc *rproc)
> >  	}
> >
> >  	priv->regmap = regmap;
> > -	regmap_attach_dev(dev, regmap, &config);
> > +	ret = regmap_attach_dev(dev, regmap, &config);
> > +	if (ret)
> > +		return dev_err_probe(dev, ret, "regmap attach
> > failed\n");
> 
> 
> In the main probe, there is already dev_err_probe for detect_mode. So
> I would use below style as other error return in
> imx_rproc_mmio_detect_mode():
> dev_err("regmap attach failed\n");
> return ret;

BTW, as Philipp mentioned in [1].
dev_err_probe is unnecessary here

[1] https://lore.kernel.org/imx/fb5e20b7-b858-4099-ad8b-900c367e1b22@web.de/T/#mc9a0a582fae1c7a0e9a203691549dfa7bccfa8f8

Regards
Peng
> 
> Let's wait Mathieu's view.
> 
> Regards
> Peng.
> 
> >
> >  	if (priv->gpr) {
> >  		ret = regmap_read(priv->gpr, dcfg->gpr_reg, &val);
> > --
> > 2.25.1
> >
>