[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <0adbe485-867f-48f5-a805-d45bfd300452@lunn.ch>
Date: Fri, 6 Feb 2026 04:47:58 +0100
From: Andrew Lunn <andrew@...n.ch>
To: "illusion.wang" <illusion.wang@...ula-matrix.com>
Cc: dimon.zhao@...ula-matrix.com, alvin.wang@...ula-matrix.com,
sam.chen@...ula-matrix.com, netdev@...r.kernel.org,
andrew+netdev@...n.ch, corbet@....net, kuba@...nel.org,
linux-doc@...r.kernel.org, lorenzo@...nel.org, pabeni@...hat.com,
horms@...nel.org, vadim.fedorenko@...ux.dev,
lukas.bulwahn@...hat.com, edumazet@...gle.com,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 net-next 05/11] net/nebula-matrix: add channel layer
> +static int nbl_chan_init_msg_handler(struct nbl_channel_mgt *chan_mgt)
> +{
> + struct nbl_common_info *common = chan_mgt->common;
> + struct nbl_hash_tbl_key tbl_key;
> + int ret = 0;
> +
> + NBL_HASH_TBL_KEY_INIT(&tbl_key, common->dev, sizeof(u16),
> + sizeof(struct nbl_chan_msg_node_data),
> + NBL_CHAN_HANDLER_TBL_BUCKET_SIZE);
> +#define NBL_HASH_TBL_KEY_INIT(key, dev_arg, key_size_arg, data_size_arg,\
> + bucket_size_arg) \
> +do { \
> + typeof(key) __key = key; \
> + __key->dev = dev_arg; \
> + __key->key_size = key_size_arg; \
> + __key->data_size = data_size_arg; \
> + __key->bucket_size = bucket_size_arg; \
> + __key->resv = 0; \
> +} while (0)
Why a macro? This could be a function. I don't see anything magical
here.
Andrew
Powered by blists - more mailing lists