linux-kernel - Re: [PATCH] dma-buf: add SB_I_NOEXEC flag to dmabuf pseudo-filesystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGHCLaRmMb9ge=KZucpXRkEbRS-VHxFQM0XyU26Y5Z6bVabLsw@mail.gmail.com>
Date: Thu, 5 Feb 2026 20:01:08 -0800
From: Cong Wang <cwang@...tikernel.io>
To: Christoph Hellwig <hch@...radead.org>
Cc: Cong Wang <xiyou.wangcong@...il.com>, linux-kernel@...r.kernel.org, 
	linux-fsdevel@...r.kernel.org, linux-media@...r.kernel.org, 
	dri-devel@...ts.freedesktop.org, Sumit Semwal <sumit.semwal@...aro.org>, 
	Christian König <christian.koenig@....com>
Subject: Re: [PATCH] dma-buf: add SB_I_NOEXEC flag to dmabuf pseudo-filesystem

On Sun, Feb 1, 2026 at 10:29 PM Christoph Hellwig <hch@...radead.org> wrote:
>
> On Sun, Feb 01, 2026 at 09:09:52AM -0800, Cong Wang wrote:
> > From: Cong Wang <cwang@...tikernel.io>
> >
> > The dmabuf filesystem uses alloc_anon_inode() to create anonymous inodes
> > but does not set the SB_I_NOEXEC flag on its superblock. This triggers a
> > VFS warning in path_noexec() when userspace mmaps a dma-buf:
>
> As last time, I think it would be much preferable to set SB_I_NOEXEC and
> SB_I_NODEV by default in init_pseudo and just clear it if needed.
>
> I can't think of anything would need to clear them from a quick look.
>

I agree that setting SB_I_NOEXEC and SB_I_NODEV by default in
init_pseudo is a better approach.

I will send a v2 tomorrow.

Thanks,
Cong