linux-kernel - Re: [PATCH v2 1/3] dt-bindings: hwmon: pmbus: mpq8785: add MPQ8786 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYWNMdfFpW2A0SGy@carl-amd>
Date: Fri, 6 Feb 2026 14:41:53 +0800
From: Carl Lee <carl.lee@....com>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, Charles Hsu <ythsu0511@...il.com>,
        linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, peter.shen@....com, colin.huang2@....com
Subject: Re: [PATCH v2 1/3] dt-bindings: hwmon: pmbus: mpq8785: add MPQ8786
 support

On Thu, Feb 05, 2026 at 08:17:07AM -0800, Guenter Roeck wrote:
> On Thu, Feb 05, 2026 at 02:46:29PM +0100, Krzysztof Kozlowski wrote:
> > On Thu, Feb 05, 2026 at 06:01:37PM +0800, Carl Lee wrote:
> > > Add device type support for MPQ8786
> > > 
> > > Signed-off-by: Carl Lee <carl.lee@....com>
> > > ---
> > >  Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml | 5 ++++-
> > >  1 file changed, 4 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> > > index 90970a0433e9..aec7397a29f9 100644
> > > --- a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> > > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> > > @@ -19,6 +19,7 @@ properties:
> > >        - mps,mpm3695-25
> > >        - mps,mpm82504
> > >        - mps,mpq8785
> > > +      - mps,mpq8786
> > 
> > Your driver code says they are the same, so compatible. Express it with
> > fallback or provide real rationale in commit msg.
> > 
> 
> Agreed. The mpq8785 datasheet is public, but the mpq8786 datasheet isn't.
> That makes it all but impossible to determine if there are indeed no
> notable differences between the chips.
> 
> Guenter

Agreed. There is no chip-specific difference in the driver code to justify
separate MPQ8786 support. 
Therefore, Therefore, I will use MPQ8785 for support.