linux-kernel - Re: [PATCH V1] accel/amdxdna: Switch to always use chained command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e90c8cc-e5c5-44e1-b0d1-dd1cba3f60fa@linux.intel.com>
Date: Fri, 6 Feb 2026 07:53:33 +0100
From: Karol Wachowski <karol.wachowski@...ux.intel.com>
To: Lizhi Hou <lizhi.hou@....com>, ogabbay@...nel.org,
 quic_jhugo@...cinc.com, dri-devel@...ts.freedesktop.org,
 maciej.falkowski@...ux.intel.com
Cc: linux-kernel@...r.kernel.org, max.zhen@....com, sonal.santan@....com,
 mario.limonciello@....com
Subject: Re: [PATCH V1] accel/amdxdna: Switch to always use chained command

On 2/6/2026 7:02 AM, Lizhi Hou wrote:
> Preempt commands are only supported when submitted as chained commands.
> To ensure preempt support works consistently, always submit commands in
> chained command format.
> 
> Set force_cmdlist to true so that single commands are filled using the
> chained command layout, enabling correct handling of preempt commands.
> 
> Fixes: 3a0ff7b98af4 ("accel/amdxdna: Support preemption requests")
> Signed-off-by: Lizhi Hou <lizhi.hou@....com>
> ---
>  drivers/accel/amdxdna/aie2_ctx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c
> index 37d05f2e986f..6378a0bc7b6e 100644
> --- a/drivers/accel/amdxdna/aie2_ctx.c
> +++ b/drivers/accel/amdxdna/aie2_ctx.c
> @@ -23,9 +23,9 @@
>  #include "amdxdna_pci_drv.h"
>  #include "amdxdna_pm.h"
>  
> -static bool force_cmdlist;
> +static bool force_cmdlist = true;
>  module_param(force_cmdlist, bool, 0600);
> -MODULE_PARM_DESC(force_cmdlist, "Force use command list (Default false)");
> +MODULE_PARM_DESC(force_cmdlist, "Force use command list (Default true)");
>  
>  #define HWCTX_MAX_TIMEOUT	60000 /* milliseconds */
>  
Reviewed-by: Karol Wachowski <karol.wachowski@...ux.intel.com>