[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <31ad6a98-66c7-4e95-b40f-ead8c594a212@gmail.com>
Date: Fri, 6 Feb 2026 15:05:23 +0800
From: Joey Lu <a0987203069@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: airlied@...il.com, simona@...ll.ch, maarten.lankhorst@...ux.intel.com,
mripard@...nel.org, tzimmermann@...e.de, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org, ychuang3@...oton.com,
schung@...oton.com, yclu4@...oton.com, linux-arm-kernel@...ts.infradead.org,
dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: display: nuvoton: add MA35D1 DCU
binding
On 2/5/2026 9:18 PM, Krzysztof Kozlowski wrote:
> On Thu, Jan 29, 2026 at 12:05:30PM +0800, Joey Lu wrote:
>> +
>> + clocks:
>> + items:
>> + - description: DCU Gate clock for register access
>> + - description: DCU Pixel clock for display timing
>> +
>> + clock-names:
>> + items:
>> + - const: dcu_gate
> That's bus or apb
>
>> + - const: dcup_div
> That's pixel
>
> Use descriptive names of functions here. Not your clock controller. It
> is completely irrelevant whether you provide here gate or div or mux or
> whatever else. If by any chance in new design you put here mux, not div,
> then completely new binding?
>
>
> Best regards,
> Krzysztof
I'll use functional clock names bus & pixel instead.
Joey
Powered by blists - more mailing lists