linux-kernel - Re: [PATCH v13 1/3] dt-bindings: i2c: Add CP2112 HID USB to SMBus Bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aYWegvvqsVhJdkCH@black.igk.intel.com>
Date: Fri, 6 Feb 2026 08:55:46 +0100
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Danny Kaehn <danny.kaehn@...xus.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Benjamin Tissoires <bentiss@...nel.org>,
	Andi Shyti <andi.shyti@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Jiri Kosina <jikos@...nel.org>,
	devicetree@...r.kernel.org, linux-input@...r.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	Ethan Twardy <ethan.twardy@...xus.com>, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, Leo Huang <leohu@...dia.com>,
	Arun D Patil <arundp@...dia.com>, Willie Thai <wthai@...dia.com>,
	Ting-Kai Chen <tingkaic@...dia.com>
Subject: Re: [PATCH v13 1/3] dt-bindings: i2c: Add CP2112 HID USB to SMBus
 Bridge

On Tue, Jan 27, 2026 at 08:47:48AM -0600, Danny Kaehn wrote:
> This is a USB HID device which includes an I2C controller and 8 GPIO pins.
> 
> The binding allows describing the chip's gpio and i2c controller in DT,
> with the i2c controller being bound to a subnode named "i2c". This is
> intended to be used in configurations where the CP2112 is permanently
> connected in hardware.

...

> +            gpio-line-names = "CP2112_SDA", "CP2112_SCL", "TEST2",
> +                              "TEST3","TEST4", "TEST5", "TEST6";


Seems like missing space. Also I would resplit this logically, id est:

            gpio-line-names = "CP2112_SDA", "CP2112_SCL",
                              "TEST2", "TEST3", "TEST4", "TEST5", "TEST6";

-- 
With Best Regards,
Andy Shevchenko