linux-kernel - Re: [PATCH v4] drm/bridge: synopsys: dw-dp: Check return value of devm_drm_bridge_add() in dw_dp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DG7Q0SEPG7IT.18FFDXBRFM4EA@bootlin.com>
Date: Fri, 06 Feb 2026 09:03:35 +0100
From: "Luca Ceresoli" <luca.ceresoli@...tlin.com>
To: "Chen Ni" <nichen@...as.ac.cn>, <andy.yan@...k-chips.com>,
 <andrzej.hajda@...el.com>, <neil.armstrong@...aro.org>, <rfoss@...nel.org>,
 <Laurent.pinchart@...asonboard.com>, <jonas@...boo.se>,
 <jernej.skrabec@...il.com>, <maarten.lankhorst@...ux.intel.com>,
 <mripard@...nel.org>, <tzimmermann@...e.de>, <airlied@...il.com>,
 <simona@...ll.ch>, <rgallaispou@...il.com>
Cc: <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>, "Andy
 Yan" <andyshrk@....com>
Subject: Re: [PATCH v4] drm/bridge: synopsys: dw-dp: Check return value of
 devm_drm_bridge_add() in dw_dp_bind()

Hello Chen, Andy,

On Fri Feb 6, 2026 at 5:06 AM CET, Chen Ni wrote:
> Return the value of devm_drm_bridge_add() in order to propagate the
> error properly, if it fails due to resource allocation failure or bridge
> registration failure.
>
> This ensures that the bind function fails safely rather than proceeding
> with a potentially incomplete bridge setup.
>
> Fixes: b726970486d8 ("drm/bridge: synopsys: dw-dp: add bridge before attaching")
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> Reviewed-by: Andy Yan <andyshrk@....com>
> ---
> Changes in v4:
> - Add Reviewed-by tag from Andy Yan <andyshrk@....com>

As far as I can see Andy reviewed v2, not this version.

Andy, if you are OK with this version it'd be great if you could tell it
clearly with a Reviewed-by, possibly on v3 which has the exact same diff
and commit message.

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com