linux-kernel - Re: [PATCH] drm/bridge: waveshare-dsi: Register and attach our DSI device at probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DG7QBWUAL0WL.1VY49M9I8ZVH@bootlin.com>
Date: Fri, 06 Feb 2026 09:18:07 +0100
From: "Luca Ceresoli" <luca.ceresoli@...tlin.com>
To: "Marek Vasut" <marek.vasut+renesas@...lbox.org>,
 <dri-devel@...ts.freedesktop.org>
Cc: "Andrzej Hajda" <andrzej.hajda@...el.com>, "David Airlie"
 <airlied@...il.com>, "Jernej Skrabec" <jernej.skrabec@...il.com>, "Jonas
 Karlman" <jonas@...boo.se>, "Laurent Pinchart"
 <Laurent.pinchart@...asonboard.com>, "Maarten Lankhorst"
 <maarten.lankhorst@...ux.intel.com>, "Maxime Ripard" <mripard@...nel.org>,
 "Neil Armstrong" <neil.armstrong@...aro.org>, "Robert Foss"
 <rfoss@...nel.org>, "Simona Vetter" <simona@...ll.ch>, "Thomas Zimmermann"
 <tzimmermann@...e.de>, <linux-kernel@...r.kernel.org>,
 <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH] drm/bridge: waveshare-dsi: Register and attach our DSI
 device at probe

Hello Marek,

On Tue Jan 13, 2026 at 12:47 AM CET, Marek Vasut wrote:
> In order to avoid any probe ordering issue, the best practice is to move
> the secondary MIPI-DSI device registration and attachment to the
> MIPI-DSI host at probe time.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@...lbox.org>

Hadn't seen this patch initially, but it caught my attention now.

> Note that this is similar to e.g. commit
> 6ef7ee48765f ("drm/bridge: sn65dsi83: Register and attach our DSI device at probe")
> and pretty much what every other DSI-to-DPI bridge does.

Digression:

  Looking at 6ef7ee48765f, I now realize it has removed one obstacle to the
  DRM bridge hotplug which I'm working to achieve. For the interested,
  there would be one more issue in addition to those I discussed in [0]
  without that commit.

  [0] https://lore.kernel.org/lkml/DE2LCFM56Z2Y.2V9NIXP26QOM2@bootlin.com/

Back to your patch, I don't have the hardware but LGTM and I'm not aware of
any issues it might cause. Still it would be good if you could describe
what goes wrong with current code.

Reviewed-by: Luca Ceresoli <luca.ceresoli@...tlin.com>

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com