linux-kernel - Re: [PATCH v1 1/2] perf tests: build-test coverage for NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260206085349.GD3529712@e132581.arm.com>
Date: Fri, 6 Feb 2026 08:53:49 +0000
From: Leo Yan <leo.yan@....com>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	James Clark <james.clark@...aro.org>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] perf tests: build-test coverage for NO_JEVENTS=1

On Thu, Feb 05, 2026 at 10:36:02AM -0800, Ian Rogers wrote:
> Leo reported the NO_JEVENTS=1 build being broken and this highlighted
> it being missing from the build-test, add it.

To be clear, I did not say the build is broken.

The issue I reported is that `perf stat` is broken, both with
NO_JEVENTS=1 enabled and without that configuration.

With updating the commit log, this patch LGTM:

Reviewed-by: Leo Yan <leo.yan@....com>

> Reported-by: Leo Yan <leo.yan@....com>
> Closes: https://lore.kernel.org/linux-perf-users/20260205175250.GC3529712@e132581.arm.com/
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/perf/tests/make | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/tests/make b/tools/perf/tests/make
> index eb41516c0562..6587dc326d1b 100644
> --- a/tools/perf/tests/make
> +++ b/tools/perf/tests/make
> @@ -70,6 +70,7 @@ make_python_perf_so := $(python_perf_so)
>  make_debug          := DEBUG=1
>  make_nondistro      := BUILD_NONDISTRO=1
>  make_extra_tests    := EXTRA_TESTS=1
> +make_no_jevents     := NO_JEVENTS=1
>  make_jevents_all    := JEVENTS_ARCH=all
>  make_no_bpf_skel    := BUILD_BPF_SKEL=0
>  make_gen_vmlinux_h  := GEN_VMLINUX_H=1
> @@ -144,6 +145,7 @@ ifneq ($(new_libbfd),)
>  run += make_nondistro
>  endif
>  run += make_extra_tests
> +run += make_no_jevents
>  run += make_jevents_all
>  run += make_no_bpf_skel
>  run += make_gen_vmlinux_h
> -- 
> 2.53.0.rc2.204.g2597b5adb4-goog
>