linux-kernel - Re: [PATCH v2 2/3] arm64: dts: nuvoton: ma35d1: add display controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c29f46c-aa27-4569-9170-53538785e029@kernel.org>
Date: Fri, 6 Feb 2026 09:56:35 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Joey Lu <a0987203069@...il.com>
Cc: airlied@...il.com, simona@...ll.ch, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, ychuang3@...oton.com,
 schung@...oton.com, yclu4@...oton.com, linux-arm-kernel@...ts.infradead.org,
 dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] arm64: dts: nuvoton: ma35d1: add display
 controller support

On 06/02/2026 08:12, Joey Lu wrote:
> 
> On 2/5/2026 9:23 PM, Krzysztof Kozlowski wrote:
>> On Thu, Jan 29, 2026 at 12:05:31PM +0800, Joey Lu wrote:
>>>   &uart0 {
>>> @@ -129,3 +165,23 @@ &uart16 {
>>>   	pinctrl-0 = <&pinctrl_uart16>;
>>>   	status = "okay";
>>>   };
>>> +
>>> +&panel {
>>> +	port {
>>> +		panel_in: endpoint@0 {
>>> +			remote-endpoint = <&dpi_out>;
>>> +		};
>>> +	};
>>> +};
>>> +
>>> +&display {
>> What sort of ordering rule is followed in Nuvoton? Why is it different
>> than DTS coding style? Why do you choose other style?
>>
>>> +	pinctrl-names = "default";
>>> +	pinctrl-0 = <&pinctrl_display>;
>>> +	status = "okay";
>>> +
>>> +	port {
>>> +		dpi_out: endpoint@0 {
>>> +			remote-endpoint = <&panel_in>;
>>> +		};
>>> +	};
>>> +};
>>> diff --git a/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi b/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi
>>> index e51b98f5bdce..7d9d077f12b2 100644
>>> --- a/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi
>>> +++ b/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi
>>> @@ -379,5 +379,19 @@ uart16: serial@...80000 {
>>>   			clocks = <&clk UART16_GATE>;
>>>   			status = "disabled";
>>>   		};
>>> +
>>> +		panel: panel {
>> No, there is no way your SoC has a panel.
>>
>> Don't add fake stuff to your DTS.
>>
>> Best regards,
>> Krzysztof
> 
> I'll move panel nodes out of dtsi into board dts.

You did not respond to several comments in total, it's fine, but if you
just ignored them, then it would not be fine.


Best regards,
Krzysztof