linux-kernel - Re: [PATCH] drm/rockchip: analogix_dp: Add missing error check for platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5eac199e-dbe3-3707-4876-f6bf7754f124@manjaro.org>
Date: Fri, 06 Feb 2026 10:21:19 +0100
From: "Dragan Simic" <dsimic@...jaro.org>
To: "Chen Ni" <nichen@...as.ac.cn>
Cc: hjc@...k-chips.com, heiko@...ech.de, andy.yan@...k-chips.com, maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch, damon.ding@...k-chips.com, dri-devel@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/rockchip: analogix_dp: Add missing error check for 
 platform_get_resource()

Hello Chen,

On Friday, February 06, 2026 09:42 CET, Chen Ni <nichen@...as.ac.cn> wrote:
> Add missing error check for platform_get_resource() return value to
> prevent NULL pointer dereference when memory resource is not available.
> 
> Fixes: 718b3bb9c0ab ("drm/rockchip: analogix_dp: Expand device data to support multiple edp display")
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>  drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> index fdab71d51e2a..3f5be14010c1 100644
> --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> @@ -461,6 +461,8 @@ static int rockchip_dp_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	if (!res)
> +		return -EINVAL;
>  
>  	i = 0;
>  	while (dp_data[i].reg) {

Thanks for this patch!  It is looking good to me, but I think it should be
propagated into the stable kernels as well.

Please feel free to include

Reviewed-by: Dragan Simic <dsimic@...jaro.org>