[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b1d791e3-849e-4d76-bda0-816418f98e39@oss.qualcomm.com>
Date: Fri, 6 Feb 2026 10:57:06 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Roger Shimizu <rosh@...ian.org>, Krzysztof Kozlowski <krzk@...nel.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley
<conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: qcs6490: Add Thundercomm AI Mini PC G1
IoT
On 2/6/26 10:55 AM, Roger Shimizu wrote:
> On Fri, Feb 6, 2026 at 1:41 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>>
>> On 04/02/2026 10:20, Konrad Dybcio wrote:
>>> On 1/31/26 11:31 AM, Roger Shimizu wrote:
>>>> ---
>>>
>>> [...]
>>>
>>>> +/ {
>>>> + model = "Thundercomm AI Mini PC G1 IoT";
>>>> + compatible = "qcom,sc7280", "qcom,qcm6490";
>>>
>>> You need to add a board-specific compatible here, see:
>>>
>>> Documentation/devicetree/bindings/arm/qcom.yaml
>>
>> The true problem is that this would probably fail validation, so I
>> suspect this was never tested/checked.
>
> Thanks for the review!
> I did test this device-tree with the board.
> If you mean some other test, please let me know in detail.
make ... CHECK_DTBS=1 qcom/qcs6490-thundercomm-minipc-g1iot.dtb
make ... dt_binding_check
Konrad
Powered by blists - more mailing lists