linux-kernel - Re: [PATCH 04/11] drm/mediatek: ovl: Enable per-plane color operations on MT8195

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e92ca2a7-7a7a-4a00-9fd8-ecacc588ffa9@collabora.com>
Date: Fri, 6 Feb 2026 11:07:44 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Nícolas F. R. A. Prado <nfraprado@...labora.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Chun-Kuang Hu <chunkuang.hu@...nel.org>,
 Philipp Zabel <p.zabel@...gutronix.de>,
 Matthias Brugger <matthias.bgg@...il.com>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 linux-mediatek@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 daniels@...labora.com, ariel.dalessandro@...labora.com, kernel@...labora.com
Subject: Re: [PATCH 04/11] drm/mediatek: ovl: Enable per-plane color
 operations on MT8195

Il 23/12/25 20:44, Nícolas F. R. A. Prado ha scritto:
> MT8195's OVL hardware supports per-plane color operations. Enable
> support for it in the driver.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>

Agreed, but you're enabling something that doesn't exist.
Please move this commit at the end, so that you enable it after it's all
implemented.

Cheers,
Angelo

> ---
>   drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> index 46238c21b0ac..cfc6a3154f73 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> @@ -738,6 +738,7 @@ static const struct mtk_disp_ovl_data mt8195_ovl_driver_data = {
>   	.fmt_rgb565_is_0 = true,
>   	.smi_id_en = true,
>   	.supports_afbc = true,
> +	.supports_plane_colorops = true,
>   	.blend_modes = BIT(DRM_MODE_BLEND_PREMULTI) |
>   		       BIT(DRM_MODE_BLEND_COVERAGE) |
>   		       BIT(DRM_MODE_BLEND_PIXEL_NONE),
>