linux-kernel - Re: [PATCH v14 12/26] crypto: iaa - Rearchitect iaa_crypto to have clean interfaces with crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aYXHM4mGlj9y2XXM@gondor.apana.org.au>
Date: Fri, 6 Feb 2026 18:49:23 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Kanchana P Sridhar <kanchana.p.sridhar@...el.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, hannes@...xchg.org,
	yosry.ahmed@...ux.dev, nphamcs@...il.com, chengming.zhou@...ux.dev,
	usamaarif642@...il.com, ryan.roberts@....com, 21cnbao@...il.com,
	ying.huang@...ux.alibaba.com, akpm@...ux-foundation.org,
	senozhatsky@...omium.org, sj@...nel.org, kasong@...cent.com,
	linux-crypto@...r.kernel.org, davem@...emloft.net,
	clabbe@...libre.com, ardb@...nel.org, ebiggers@...gle.com,
	surenb@...gle.com, kristen.c.accardi@...el.com,
	vinicius.gomes@...el.com, giovanni.cabiddu@...el.com,
	wajdi.k.feghali@...el.com
Subject: Re: [PATCH v14 12/26] crypto: iaa - Rearchitect iaa_crypto to have
 clean interfaces with crypto_acomp.

On Sat, Jan 24, 2026 at 07:35:23PM -0800, Kanchana P Sridhar wrote:
>
> +static int iaa_crypto_acomp_init_fixed(struct crypto_acomp *acomp_tfm)
>  {
>  	struct crypto_tfm *tfm = crypto_acomp_tfm(acomp_tfm);
>  	struct iaa_compression_ctx *ctx = crypto_tfm_ctx(tfm);
>  
> -	ctx->mode = IAA_MODE_FIXED;
> -
> -	compression_ctx_init(ctx);
> +	ctx = iaa_ctx[IAA_MODE_FIXED];

Gcc warns about ctx as this line does nothing.  What is meant to
initialize?

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt