linux-kernel - Re: [PATCH 2/5] devres: export devres_node_init() and devres_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2026020633-democrat-moisten-631a@gregkh>
Date: Fri, 6 Feb 2026 12:04:28 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Danilo Krummrich <dakr@...nel.org>
Cc: rafael@...nel.org, ojeda@...nel.org, boqun.feng@...il.com,
	gary@...yguo.net, bjorn3_gh@...tonmail.com, lossin@...nel.org,
	a.hindborg@...nel.org, aliceryhl@...gle.com, tmgross@...ch.edu,
	driver-core@...ts.linux.dev, rust-for-linux@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] devres: export devres_node_init() and
 devres_node_add()

On Fri, Feb 06, 2026 at 11:43:48AM +0100, Danilo Krummrich wrote:
> On Thu Feb 5, 2026 at 11:31 PM CET, Danilo Krummrich wrote:
> > +EXPORT_SYMBOL_GPL(devres_node_init);
> 
> I actually intended to use a Rust helper instead of exporting those symbols
> directly, but forgot to do it eventually.
> 

I don't understand, does that mean we do not need to export these?
Shouldn't the rust bindings just export these symbols are rust exports,
and the C exports are not needed?

We "only" want these symbols to go to the rust binding, not to any
module at all, which is what this patch series does, and is probably not
a good idea.

thanks,

greg k-h