linux-kernel - Re: [PATCH] usb: typec: ucsi: Add Thunderbolt alternate mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMMMRMcBKWdVmXG_fHhOmiSdihxLGyrjTGeS0vvYF31FTfucgA@mail.gmail.com>
Date: Fri, 6 Feb 2026 12:08:55 +0100
From: Andrei Kuchynski <akuchynski@...omium.org>
To: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc: Jameson Thies <jthies@...gle.com>, Benson Leung <bleung@...omium.org>, linux-usb@...r.kernel.org, 
	linux-kernel@...r.kernel.org, 
	Abhishek Pandit-Subedi <abhishekpandit@...omium.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>, Pooja Katiyar <pooja.katiyar@...el.com>, 
	Johan Hovold <johan@...nel.org>, Hsin-Te Yuan <yuanhsinte@...omium.org>, Madhu M <madhu.m@...el.com>, 
	Venkat Jayaraman <venkat.jayaraman@...el.com>, Pengyu Luo <mitltlatltl@...il.com>, 
	Fedor Pchelkin <boddah8794@...il.com>
Subject: Re: [PATCH] usb: typec: ucsi: Add Thunderbolt alternate mode support

Hi Heikki,

On Fri, Feb 6, 2026 at 9:58 AM Heikki Krogerus
<heikki.krogerus@...ux.intel.com> wrote:
>
> Hi Andrei,
>
> On Mon, Jan 26, 2026 at 09:06:16AM +0000, Andrei Kuchynski wrote:
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * UCSI Thunderbolt Alternate Mode Support
> > + *
> > + * Copyright 2025 Google LLC
>
> 2026

Thanks for catching the year; time flies!

>
> > + */
> > +
> > +#include <linux/usb/typec_tbt.h>
> > +#include <linux/usb/pd_vdo.h>
>
> We now need to include everything instead of relying other
> headers to do that for us (although, I don't think this rule is
> documented anywhere yet). Include at least these:
>
> linux/err.h
> linux/dev_printk.h
> linux/device/devres.h
> linux/gfp_types.h
> linux/types.h
> linux/usb/typec_altmode.h
> linux/workqueue.h

Understood. I will explicitly include all necessary headers. I'll fix this
in v2.

>
> Otherwise this looks good to me.
>
> thanks,
>
> --
> heikki

Thank you for the review!

Andrei