linux-kernel - Re: [PATCH v6 2/4] rust: generate a fatal error if BINDGEN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c1e37734-271f-440d-a391-91e958aa89ad@isrc.iscas.ac.cn>
Date: Fri, 6 Feb 2026 20:41:53 +0800
From: Asuna Yang <xinrui.riscv@...c.iscas.ac.cn>
To: Nathan Chancellor <nathan@...nel.org>
Cc: xinrui.riscv@...c.iscas.ac.cn, Nicolas Schier <nsc@...nel.org>,
 Miguel Ojeda <ojeda@...nel.org>, Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, Benno Lossin <lossin@...nel.org>,
 Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>,
 Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
 Bill Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>,
 Paul Walmsley <pjw@...nel.org>, Palmer Dabbelt <palmer@...belt.com>,
 Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
 Jonathan Corbet <corbet@....net>, Conor Dooley <conor@...nel.org>,
 Mingcong Bai <jeffbai@...c.io>, Han Gao <rabenda.cn@...il.com>,
 Vivian Wang <wangruikang@...as.ac.cn>, Jason Montleon <jmontleo@...hat.com>,
 linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
 rust-for-linux@...r.kernel.org, llvm@...ts.linux.dev,
 linux-riscv@...ts.infradead.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v6 2/4] rust: generate a fatal error if BINDGEN_TARGET is
 undefined

On 1/30/26 06:40, Nathan Chancellor wrote:

> This might read a little better if it were
> 
>    scripts/Makefile.rust is included ..., so we perform ...
> 
> instead of
> 
>    Because ..., we perform ...
> 
> or at the very least reversing the phrases
> 
>    We perform ... because ...
> 
> But that could just be personal preference.

I think you're right. Since I'm not a native English speaker, some of my 
phrasing might not sound quite natural.

However, considering this isn't really a big deal, I'd prefer to skip 
submitting a new patch to fix it. Unlike GitHub, I'm concerned that a 
new patch might make too much noise on the mailing list and interrupt 
the thread.

Or if someone could help modify it when merging this patch, that would 
be better! I've read the docs, and the kernel tree seems to allow this 
practice.

Best regards,
Asuna