linux-kernel - Re: [PATCH v5 1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEev2e99LEoi83_d09NEJwzcSiYdFFZvLOFZUTRRrYtL_qCErw@mail.gmail.com>
Date: Fri, 6 Feb 2026 22:18:13 -0600
From: Anirudh Srinivasan <asrinivasan@....tenstorrent.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Drew Fustini <dfustini@....tenstorrent.com>, Joel Stanley <jms@....tenstorrent.com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
	Philipp Zabel <p.zabel@...gutronix.de>, linux-riscv@...ts.infradead.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-clk@...r.kernel.org, joel@....id.au, fustini@...nel.org, mpe@...nel.org, 
	mpe@....tenstorrent.com, npiggin@....tenstorrent.com, agross@...nel.org, 
	agross@....tenstorrent.com, bmasney@...hat.com
Subject: Re: [PATCH v5 1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm

On Thu, Feb 5, 2026 at 12:45 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 05/02/2026 15:31, Anirudh Srinivasan wrote:
> >>> +examples:
> >>> +  - |
> >>> +    clock-controller@...00000 {
> >>> +      compatible = "tenstorrent,atlantis-prcm-rcpu";
> >>> +      reg = <0xa8000000 0x10000>;
> >>> +      clocks = <&osc_24m>;
> >>> +      #clock-cells = <1>;
> >>> +      #reset-cells = <1>;
> >>> +    };
> >>> diff --git a/MAINTAINERS b/MAINTAINERS
> >>> index dc731d37c8fe..0fc7bc6d0458 100644
> >>> --- a/MAINTAINERS
> >>> +++ b/MAINTAINERS
> >>> @@ -22534,8 +22534,10 @@ M:   Joel Stanley <jms@....tenstorrent.com>
> >>>  L:   linux-riscv@...ts.infradead.org
> >>>  S:   Maintained
> >>>  T:   git https://github.com/tenstorrent/linux.git
> >>> +F:   Documentation/devicetree/bindings/clock/tenstorrent,atlantis-prcm.yaml
> >>>  F:   Documentation/devicetree/bindings/riscv/tenstorrent.yaml
> >>>  F:   arch/riscv/boot/dts/tenstorrent/
> >>> +F:   include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
> >>>
> >>>  RISC-V THEAD SoC SUPPORT
> >>>  M:   Drew Fustini <fustini@...nel.org>
> >>> diff --git a/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h b/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
> >>> new file mode 100644
> >>> index 000000000000..3820781127c3
> >>> --- /dev/null
> >>> +++ b/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
> >>
> >> Still wrong name... Look at your compatible.
> >>
> >> Please read writing bindings doc in DT dir.
> >
> > We will have multiple compatibles in the future (I dropped these in
>
> Maybe you will, maybe not. But you do not have now.

Let me add them now.

>
> > this version and I have mentioned this in the changelog in the cover
> > letter) named "tenstorrent,atlantis-prcm-xyz". The bindings document
>
> Where did you mention it? I went TWICE through it.

Conor and I were discussing these in a previous series and were
referring to them as rcpu prcm and !rcpu prcms. I use these terms to
refer to it in "Changes in v4".

>
> > suggests picking a more generic name in this case, so isn't
> > "tenstorrent,atlantis-prcm" okay for that?
>
> No, because I don't want to keep guessing this. The docs clearly ask you
> to post complete bindings, which now became less-complete, but fine.
> Then the next rule asks you to use compatible as filename. You cannot
> keep skipping the rules.

I will add all the compatibles back, so there will be 4 of them named
"tenstorrent,atlantis-prcm-xyz". In that case is it appropriate for
the filename to be "tenstorrent,atlantis-prcm.yaml"?

>
> Best regards,
> Krzysztof