linux-kernel - Re: [PATCH] i2c: tegra: Don't mark devices with pins as IRQ safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aYaFv81tlNHY4a0n@zenone.zhora.eu>
Date: Sat, 7 Feb 2026 01:25:02 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Mikko Perttunen <mperttunen@...dia.com>
Cc: Dmitry Osipenko <digetx@...il.com>, 
	Thierry Reding <thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>, 
	linux-i2c@...r.kernel.org, linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: tegra: Don't mark devices with pins as IRQ safe

Hi Mikko,

> -	if (!IS_VI(i2c_dev) && !has_acpi_companion(i2c_dev->dev))
> +	if (!IS_VI(i2c_dev) && !has_acpi_companion(i2c_dev->dev) && !i2c_dev->dev->pins)

I'm sorry, I had to remove your patch. The ->pins member is
conditional to CONFIG_PINCTRL, without it we get this compile
error:

   drivers/i2c/busses/i2c-tegra.c: In function 'tegra_i2c_probe':
>> drivers/i2c/busses/i2c-tegra.c:1842:82: error: 'struct device' has no member named 'pins'
    1842 |         if (!IS_VI(i2c_dev) && !has_acpi_companion(i2c_dev->dev) && !i2c_dev->dev->pins)
         |                                                                                  ^~

Please fix it and resubmit a v2.

Thanks,
Andi