[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20260207051114.GA2289557@ax162>
Date: Fri, 6 Feb 2026 23:11:14 -0600
From: Nathan Chancellor <nathan@...nel.org>
To: Christian Brauner <brauner@...nel.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL 12/12 for v7.0] vfs misc
On Fri, Feb 06, 2026 at 05:50:08PM +0100, Christian Brauner wrote:
> David Laight (1):
> fs: use min() or umin() instead of min_t()
This needs a fix up for 32-bit builds:
https://lore.kernel.org/20260113192243.73983-1-david.laight.linux@gmail.com/
$ make -skj"$(nproc)" ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- mrproper allmodconfig fs/fuse/file.o
In file included from <command-line>:
In function 'fuse_wr_pages',
inlined from 'fuse_perform_write' at fs/fuse/file.c:1347:27:
include/linux/compiler_types.h:705:45: error: call to '__compiletime_assert_508' declared with attribute error: min(((pos + len - 1) >> 12) - (pos >> 12) + 1, max_pages) signedness error
705 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^
include/linux/compiler_types.h:686:25: note: in definition of macro '__compiletime_assert'
686 | prefix ## suffix(); \
| ^~~~~~
include/linux/compiler_types.h:705:9: note: in expansion of macro '_compiletime_assert'
705 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
| ^~~~~~~~~~~~~~~~~~
include/linux/minmax.h:93:9: note: in expansion of macro 'BUILD_BUG_ON_MSG'
93 | BUILD_BUG_ON_MSG(!__types_ok(ux, uy), \
| ^~~~~~~~~~~~~~~~
include/linux/minmax.h:98:9: note: in expansion of macro '__careful_cmp_once'
98 | __careful_cmp_once(op, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_))
| ^~~~~~~~~~~~~~~~~~
include/linux/minmax.h:105:25: note: in expansion of macro '__careful_cmp'
105 | #define min(x, y) __careful_cmp(min, x, y)
| ^~~~~~~~~~~~~
fs/fuse/file.c:1326:16: note: in expansion of macro 'min'
1326 | return min(((pos + len - 1) >> PAGE_SHIFT) - (pos >> PAGE_SHIFT) + 1,
| ^~~
David sent another patch before that one (though it does not look like
you were explicitly sent that one). Arnd also sent one.
https://lore.kernel.org/20251216141647.13911-1-david.laight.linux@gmail.com/
https://lore.kernel.org/20251223215442.720828-1-arnd@kernel.org/
Cheers,
Nathan
Powered by blists - more mailing lists