[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <k2t4jm6vqkrp46reo3nhr4e5awthm4gu2crow3hnl254p33ywo@pbbdhtdq5ag7>
Date: Sat, 7 Feb 2026 11:09:08 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Maulik Shah <maulik.shah@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>, Linus Walleij <linusw@...nel.org>,
Lijuan Gao <quic_lijuang@...cinc.com>, linux-arm-msm@...r.kernel.org,
linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: qcom: qcs615: Add missing dual edge GPIO IRQ
errata flag
On Sat, Feb 07, 2026 at 01:03:30PM +0530, Maulik Shah wrote:
> Configuring GPIO IRQ as dual edge breaks as the wakeirq_dual_edge_errata is
> not set. Add missing wakeirq_dual_edge_errata flag.
It breaks because HW doesn't support it, not because the flag is not
set.
>
> Fixes: b698f36a9d40 ("pinctrl: qcom: add the tlmm driver for QCS615 platform")
> Signed-off-by: Maulik Shah <maulik.shah@....qualcomm.com>
> ---
> drivers/pinctrl/qcom/pinctrl-qcs615.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-qcs615.c b/drivers/pinctrl/qcom/pinctrl-qcs615.c
> index 4dfa820d4e77ce8157a3503ee8ec6e426b54e030..f1c827ddbfbfa59d03ddea560eca36ffa997aa8d 100644
> --- a/drivers/pinctrl/qcom/pinctrl-qcs615.c
> +++ b/drivers/pinctrl/qcom/pinctrl-qcs615.c
> @@ -1067,6 +1067,7 @@ static const struct msm_pinctrl_soc_data qcs615_tlmm = {
> .ntiles = ARRAY_SIZE(qcs615_tiles),
> .wakeirq_map = qcs615_pdc_map,
> .nwakeirq_map = ARRAY_SIZE(qcs615_pdc_map),
> + .wakeirq_dual_edge_errata = true,
> };
>
> static const struct of_device_id qcs615_tlmm_of_match[] = {
>
> ---
> base-commit: 9845cf73f7db6094c0d8419d6adb848028f4a921
> change-id: 20260207-qcs615_gpio-7b76c94f6921
>
> Best regards,
> --
> Maulik Shah <maulik.shah@....qualcomm.com>
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists