linux-kernel - Re: [PATCH v2 1/3] dt-bindings: display: lt9611: Support single Port B input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEQ9gEkEiNS83b4ptogzXZH8FsoUWHSZ8NabNHMRjJ0LegxXig@mail.gmail.com>
Date: Sat, 7 Feb 2026 02:35:06 -0800
From: Roger Shimizu <rosh@...ian.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Hongyang Zhao <hongyang.zhao@...ndersoft.com>, Andrzej Hajda <andrzej.hajda@...el.com>, 
	Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>, 
	Laurent Pinchart <Laurent.pinchart@...asonboard.com>, Jonas Karlman <jonas@...boo.se>, 
	Jernej Skrabec <jernej.skrabec@...il.com>, David Airlie <airlied@...il.com>, 
	Simona Vetter <simona@...ll.ch>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Vinod Koul <vkoul@...nel.org>, 
	Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: display: lt9611: Support single Port
 B input

On Sat, Feb 7, 2026 at 1:35 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 07/02/2026 06:22, Roger Shimizu wrote:
> > On Fri, Feb 6, 2026 at 2:56 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> >>
> >> On 06/02/2026 10:49, Roger Shimizu wrote:
> >>> On Thu, Feb 5, 2026 at 11:08 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> >>>>
> >>>> On 05/02/2026 21:31, Roger Shimizu wrote:
> >>>>> On Thu, Feb 5, 2026 at 5:07 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> >>>>>>
> >>>>>> On Wed, Jan 28, 2026 at 07:15:45PM +0800, Hongyang Zhao wrote:
> >>>>>>> The LT9611 has two DSI input ports (Port A and Port B). Update the
> >>>>>>> binding to clearly document the port mapping and allow using Port B
> >>>>>>> alone when DSI is physically connected to Port B only.
> >>>>>>>
> >>>>>>> Changes:
> >>>>>>> - Clarify port@0 corresponds to DSI Port A input
> >>>>>>> - Clarify port@1 corresponds to DSI Port B input
> >>>>>>> - Change port requirement from mandatory port@0 to anyOf port@...ort@1,
> >>>>>>>   allowing either port to be used independently
> >>>>>>>
> >>>>>>> Signed-off-by: Hongyang Zhao <hongyang.zhao@...ndersoft.com>
> >>>>>>> Reviewed-by: Roger Shimizu <rosh@...ian.org>
> >>>>>>
> >>>>>> Where did this review happen? V1 had this tag, but the patch was
> >>>>>> completely different, which means you were supposed to drop the tag.
> >>>>>> Please perform review in public.
> >>>>>
> >>>>> FYI. v2 was updated per review feedback, which is public:
> >>>>> https://lore.kernel.org/all/7d9041a3-9d2b-469a-9fa7-89d53bbd2a1f@linaro.org/
> >>>>
> >>>> Link above is not from Roger, so again - where did the review leading to
> >>>> above tag happen?
> >>>
> >>> Per feedback of v1, v2 was quite different than v1.
> >>> For v2, it's close to initial review, because it looks like a new patch.
> >>
> >> Where was the review of v2 given?
> >>
> >> The patch is entirely different. I already said it. I also said what is
> >> expected in such case. It is also documented:
> >>
> >> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
> >
> > Thanks for the guide!
> > Yes, v2 was reviewed in private. I'll inform Hongyang to remove the
> > tag when he sends the next series.
>
> I am repeating myself but only because you really avoid answering.

Because I just didn't have the time to check when exactly it happened.
I agree with you that if it's public, then it's easier to check the
mailing list.

> I understand v1 was reviewed in private, before posting, but why are you
> developing in private also v2? After v1 was posted, this should be all
> done in public.

Hongyang wrote the patch. Credit to him.
I just helped to check.
v2 was a rewrite since feedback of v1, so we think it's like new
patch, which was reviewed in private.

> I have no trust in private reviews happening between versions.
> Especially if v1 is send on 27th Jan and next day v2 is sent supposedly
> reviewed in private. Really?

This patch is not huge amount of work, in spite of rewriting from v1.
I understand that it's not good to resend a series too quickly, but
for this specific case, the feedback was very convincing, so v2 was
sent out without much waiting.
If you insist on some more waiting period, we can follow it next time.

-Roger