linux-kernel - Re: [PATCH] pstore: ram_core: fix incorrect success return when vmap() fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <177042549530.3947477.12730856527038867205.b4-ty@kernel.org>
Date: Fri,  6 Feb 2026 16:51:37 -0800
From: Kees Cook <kees@...nel.org>
To: ruipengqi <ruipengqi3@...il.com>
Cc: Kees Cook <kees@...nel.org>,
	tony.luck@...el.com,
	gpiccoli@...lia.com,
	linux-hardening@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pstore: ram_core: fix incorrect success return when vmap() fails

On Tue, 03 Feb 2026 10:03:58 +0800, ruipengqi wrote:
> In persistent_ram_vmap(), vmap() may return NULL on failure.
> 
> If offset is non-zero, adding offset_in_page(start) causes the function
> to return a non-NULL pointer even though the mapping failed.
> persistent_ram_buffer_map() therefore incorrectly returns success.
> 
> Subsequent access to prz->buffer may dereference an invalid address
> and cause crashes.
> 
> [...]

Applied to for-next/pstore, thanks!

[1/1] pstore: ram_core: fix incorrect success return when vmap() fails
      https://git.kernel.org/kees/c/05363abc7625

Take care,

-- 
Kees Cook