linux-kernel - Re: [PATCH v3] staging: most: dim2: convert pr_info/err/warn to dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026020726-ruckus-imperfect-6ca5@gregkh>
Date: Sat, 7 Feb 2026 12:57:08 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Zeeshan Ahmad <zeeshanahmad022019@...il.com>
Cc: Parthiban Veerasooran <parthiban.veerasooran@...rochip.com>,
	Christian Gromm <christian.gromm@...rochip.com>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	Ethan Tidmore <ethantidmore06@...il.com>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] staging: most: dim2: convert pr_info/err/warn to
 dev_info/err/warn

On Sat, Feb 07, 2026 at 12:56:15PM +0100, Greg Kroah-Hartman wrote:
> On Sat, Feb 07, 2026 at 07:34:32AM +0500, Zeeshan Ahmad wrote:
> > The dim2 driver currently uses generic pr_* logging macros. Hardware
> > drivers should use the device-specific dev_* logging macros to provide
> > better context in the system logs, especially in systems with multiple
> > controller instances.
> > 
> > This patch converts all applicable logging calls in dim2.c to use the
> > proper device-specific APIs.
> > 
> > Signed-off-by: Zeeshan Ahmad <zeeshanahmad022019@...il.com>
> > ---
> > v3:
> >  - Removed "staging-next" and redundant "[PATCH]" from the subject line.
> >  - Shortened commit message lines to stay under 75 characters.
> >  - Added this changelog below the "---" as suggested by Ethan Tidmore.
> >  - Cleaned up temporary submission notes from the permanent commit body.
> > v2:
> >  - Rebased against the staging-next branch.
> >  - Fixed CC list to include relevant maintainers.
> > 
> >  drivers/staging/most/dim2/dim2.c | 44 ++++++++++++++++----------------
> >  1 file changed, 22 insertions(+), 22 deletions(-)
> > 
> > diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c
> > index 80af965356d0..4bcafda481f9 100644
> > --- a/drivers/staging/most/dim2/dim2.c
> > +++ b/drivers/staging/most/dim2/dim2.c
> > @@ -246,9 +246,9 @@ static void retrieve_netinfo(struct dim2_hdm *dev, struct mbo *mbo)
> >  {
> >  	u8 *data = mbo->virt_address;
> >  
> > -	pr_info("Node Address: 0x%03x\n", (u16)data[16] << 8 | data[17]);
> > +	dev_info(&dev->dev, "Node Address: 0x%03x\n", (u16)data[16] << 8 | data[17]);
> 
> My review comments from your v1 patch remain the same here.

And note, that's the problem with going "too fast", you spent time
respinning patches without allowing others to review the original patch.
Please slow down and send updates maybe once a week.  There is no rush
here.

thanks,

greg k-h