linux-kernel - Re: [PATCH] staging: greybus: uart: migrated from IDR to XArray API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026020735-thumping-chemicals-c76e@gregkh>
Date: Sat, 7 Feb 2026 14:25:12 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Neel Bullywon <neelb2403@...il.com>
Cc: David Lin <dtwlin@...il.com>, Johan Hovold <johan@...nel.org>,
	Alex Elder <elder@...nel.org>, greybus-dev@...ts.linaro.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: greybus: uart: migrated from IDR to XArray API

On Tue, Feb 03, 2026 at 11:38:02PM -0500, Neel Bullywon wrote:
> Replaced the IDR API with the XArray API for managing TTY minor numbers.
> This addresses the checkpatch warning about DEFINE_IDR being deprecated.

While I understand that some people might feel that xarrays are the
bees-knees, for something "simple" like an idr, it's overkill, right?

This is "just" a unique integer that is used for a device name, leaving
it as an idr should be just fine as there is no performance or storage
issues with it as-is.

So while I'm all for using new apis for new code, unless all usages of
idr is going to be replaced in the kernel with xarray, I don't really
feel that this is needed to be done here, sorry.

thanks,

greg k-h