linux-kernel - Re: [PATCH v3 3/5] staging: sm750fb: remove debug and diagnostic prints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026020701-radar-onward-20a4@gregkh>
Date: Sat, 7 Feb 2026 14:32:33 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Artem Lytkin <iprintercanon@...il.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Teddy Wang <teddy.wang@...iconmotion.com>,
	linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/5] staging: sm750fb: remove debug and diagnostic
 prints

On Wed, Feb 04, 2026 at 12:06:00PM +0000, Artem Lytkin wrote:
> @@ -811,11 +802,8 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
>  				g_fbmode[index],
>  				mdb_desc[i]);
>  			break;
> -		} else if (ret == 3) {
> -			pr_warn("wanna use default mode\n");
> -			/*break;*/
> -		} else if (ret == 4) {
> -			pr_warn("fall back to any valid mode\n");
> +		} else if (ret == 3 || ret == 4) {
> +			continue;
>  		} else {
>  			pr_warn("ret = %d,fb_find_mode failed,with %s\n",
>  				ret,

Why delete some of these but not all?  Why delete any of them?

Consistancy matters :)

thanks,

greg k-h