linux-kernel - Re: [PATCH v3] [PATCH v3] staging: greybus: gbphy: Replace sprintf() with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026020730-superhero-secrecy-877a@gregkh>
Date: Sat, 7 Feb 2026 14:37:01 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Neel Bullywon <neelb2403@...il.com>
Cc: Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
	greybus-dev@...ts.linaro.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] [PATCH v3] staging: greybus: gbphy: Replace sprintf()
 with sysfs_emit()

On Wed, Feb 04, 2026 at 10:34:08PM -0500, Neel Bullywon wrote:
> Replace sprintf() with sysfs_emit() in the protocol_id_show() sysfs
> attribute function. This code is safe as-is, but replace
> sprintf() with sysfs_emit() because we are trying to get rid of calls
> to sprintf() as part of kernel hardening; sysfs_emit() is more
> appropriate in this context.
> 
> Signed-off-by: Neel Bullywon <neelb2403@...il.com>
> ---
> This was compile-tested only (no VM/hardware used)
> 
> Changes in v2:
> - Subject: change to imperative "Replace" (was "Replaced").
> - Wording and line breaks adjusted in the commit body for clarity.
> 
> Changes in v3:
> - Clarify what "safe" means (buffer is PAGE_SIZE) per Dan Carpenter's
>   suggestion.
> - Reflow lines to avoid awkward breaks.
> ---
>  drivers/staging/greybus/gbphy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c
> index 60cf09a302a7..55f132b09cee 100644
> --- a/drivers/staging/greybus/gbphy.c
> +++ b/drivers/staging/greybus/gbphy.c
> @@ -31,7 +31,7 @@ static ssize_t protocol_id_show(struct device *dev,
>  {
>  	struct gbphy_device *gbphy_dev = to_gbphy_dev(dev);
>  
> -	return sprintf(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id);
> +	return sysfs_emit(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id);

For new sysfs files, using sysfs_emit() is fine, but for existing ones,
using sprintf() is also ok, just leave them as-is please.

thanks,

greg k-h